[Mobile Payments] Make Preparing Reader background one color #8223
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the Preparing Reader modal, the borders of the hosting controller view can be bigger than the spinner view itself – this is the case on iPad. It was observed that in dark mode, this shows with two black bars, above and below the spinner. This changes the background specifier to be on the hosting controller’s view, not the spinner contained within it, which corrects the background color issue.
joshheald
added
type: bug
Contributor
Author
|
@koke I've put it as 11.5, but could go in 11.4 if we're quick. Not a big deal either way. @jostnes @JorgeMucientes added you as optional reviewers since you found the issue in beta testing. |
Collaborator
You can test the changes from this Pull Request by:
|
koke
approved these changes
Nov 25, 2022
Member
koke
left a comment
koke
left a comment
There was a problem hiding this comment.
It feels slightly odd to set the background on the view from the outside, but I guess it works well enough 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8222
Description
On the Preparing Reader modal, the borders of the hosting controller view can be bigger than the spinner view itself – this is the case on iPad.
It was observed that in dark mode, this shows with two black bars, above and below the spinner.
This changes the background specifier to be on the hosting controller’s view, not the spinner contained within it, which corrects the background color issue.
Testing instructions
Menu > Payments > Collect PaymentCardon the payment method screenScreenshots
ipad-spinner-background-fixed.-.01.mp4
RELEASE-NOTES.txtif necessary.